Add helpers to directly push properties and indexes to pointers #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark (macos)
| Benchmark suite | Current: dbe6349 | Previous: 100f800 | Ratio |
|---|---|---|---|
JSONSchema_Compile_Basic |
210283.48158379376 ns/iter |
196739.80349593566 ns/iter |
1.07 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
1517.935184283406 ns/iter |
1459.1904001457274 ns/iter |
1.04 |
JSONSchema_Validate_Draft4_Required_Properties |
2342.9147049836456 ns/iter |
2192.3736454390746 ns/iter |
1.07 |
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match |
175.0668784725498 ns/iter |
168.9707013745326 ns/iter |
1.04 |
JSONSchema_Validate_Draft4_Items_Schema |
9199.331005326198 ns/iter |
8000.260824872715 ns/iter |
1.15 |
JSONSchema_Validate_Draft4_Nested_Object |
7280.216680078243 ns/iter |
6657.047873411632 ns/iter |
1.09 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: Juan Cruz Viotti <[email protected]>
jviotti
force-pushed
the
pointer-push-back-token
branch
from
e952f1e
to
dbe6349
Compare
There was a problem hiding this comment.
Benchmark (linux/gcc)
| Benchmark suite | Current: dbe6349 | Previous: 100f800 | Ratio |
|---|---|---|---|
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
2063.2960880746996 ns/iter |
2133.353085342925 ns/iter |
0.97 |
JSONSchema_Validate_Draft4_Required_Properties |
2656.895038074802 ns/iter |
2854.4597776164687 ns/iter |
0.93 |
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match |
215.0405303261176 ns/iter |
220.10896465478882 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Items_Schema |
10210.400792311042 ns/iter |
10885.629297294758 ns/iter |
0.94 |
JSONSchema_Validate_Draft4_Nested_Object |
8804.028468103272 ns/iter |
9133.516872674156 ns/iter |
0.96 |
JSONSchema_Compile_Basic |
386395.35840706615 ns/iter |
390391.87192395807 ns/iter |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (windows)
| Benchmark suite | Current: dbe6349 | Previous: 100f800 | Ratio |
|---|---|---|---|
JSONSchema_Compile_Basic |
784623.660714396 ns/iter |
788528.3482142062 ns/iter |
1.00 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
4728.283098846265 ns/iter |
4810.3774785208725 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Required_Properties |
3680.652315653802 ns/iter |
3639.2914166021046 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match |
723.9066964283479 ns/iter |
749.2447544640765 ns/iter |
0.97 |
JSONSchema_Validate_Draft4_Items_Schema |
24829.450564165392 ns/iter |
25355.24285713921 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Nested_Object |
18405.734872629946 ns/iter |
18635.836927112654 ns/iter |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/llvm)
| Benchmark suite | Current: dbe6349 | Previous: 100f800 | Ratio |
|---|---|---|---|
JSONSchema_Compile_Basic |
385649.88745386904 ns/iter |
392755.5706150269 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Meta_1_No_Callback |
18720.517196400568 ns/iter |
18505.237985006952 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Required_Properties |
7867.2884372608005 ns/iter |
8026.92325071907 ns/iter |
0.98 |
JSONSchema_Validate_Draft4_Optional_Properties_Minimal_Match |
1706.911941932038 ns/iter |
1693.2734273344367 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Items_Schema |
115509.23837017114 ns/iter |
114028.04270174386 ns/iter |
1.01 |
JSONSchema_Validate_Draft4_Nested_Object |
57364.001080092865 ns/iter |
57334.1509092435 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti [email protected]